Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output_format matching more robust. #1

Merged
merged 2 commits into from
Jan 1, 2015

Commits on Dec 31, 2014

  1. Make output_format matching more robust.

    The issue at ruby-av/paperclip-av-transcoder#3
    is caused, at least on my system with Paperclip 4.2, by the format
    parameter of the form: ".FMT".  This caused the case statement to not
    match any of the desired formats!  It's likely that other paperclip
    version don't pass the dot before the format extension, but it seems
    likely that the behavior may differ depending on the version.
    
    This change looks for the end of the format string to match using a
    regex, and should now properly find the format, allowing thumbnails
    to be generated (as well as the proper switches for non image params)
    edk committed Dec 31, 2014
    Configuration menu
    Copy the full SHA
    fee7c42 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2015

  1. Fix failing Spec.

    It was failing because it was manually adding the output_type,
    while the Base#add_destination does it as well, causing the
    options, aac and experimental to be added twice.
    
    While this fixes the issue, I wonder if it might be better
    to make the option setting idempontent?  Although with command-
    line switches, I suppose one never knows when repeated arguments
    are valid and necessary.
    edk committed Jan 1, 2015
    Configuration menu
    Copy the full SHA
    a5d136a View commit details
    Browse the repository at this point in the history