Fix the doc of Concurrent.available_processor_count
#1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Aug 8, 2024
|
cc @byroot |
Currently, the doc says that this methods returns `nil` if there is no cpu_quota, but actually not. https://github.com/ruby-concurrency/concurrent-ruby/blob/6f7c91ab5a4e99d850f69c958572a536426277e8/lib/concurrent-ruby/concurrent/utility/processor_counter.rb#L30 This PR fixes the doc to match the behavior. Co-authored-by: Benoit Daloze <eregontp@gmail.com>
y-yagi
force-pushed
the
fix_doc_for_available_processor_count
branch
from
cdcd44f
to
f8f3356
Compare
byroot
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the doc says that this methods returns
nilif there is no cpu_quota, but actually not.concurrent-ruby/lib/concurrent-ruby/concurrent/utility/processor_counter.rb
Line 30 in 6f7c91a
This PR fixes the doc to match the behavior.