Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed syntax error on ruby 1.8 #154

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Fixed syntax error on ruby 1.8 #154

merged 1 commit into from
Jul 6, 2018

Conversation

encyphered
Copy link
Contributor

Ruby 1.8 does not support default value in block arguments. I have no idea about the project is still support Ruby 1.8, but when notify_dispatcher_if_needed method yield, the 2nd argument that named port_changed cannot be nil. So, I've removed setting false as the default value of an argument.

@valich
Copy link
Contributor

valich commented Jul 6, 2018

@encyphered We do not add new functionality to older rubies if there are incompatibility difficulties, but we try to make the existing features work properly.
Thanks, this fix looks correct.

@valich valich merged commit 235f8fa into ruby-debug:master Jul 6, 2018
@encyphered encyphered deleted the ruby1.8-fix branch March 14, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants