Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #paragraphs grabs paragraphs in tables #76

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Fix: #paragraphs grabs paragraphs in tables #76

merged 1 commit into from
Dec 30, 2019

Conversation

satoryu
Copy link
Member

@satoryu satoryu commented Dec 14, 2019

With the current version of the gem, Docx::Document#paragraphs grabs paragraphs in tables.
I expected the method paragraphs grabs paragraphs in the doc not in tables as Docx::Document provides #tables method for us to grabs paragraphs in tables.

This pull-request provides a change on xpath used in the method to grabs all paragraphs in a doc except for ones in tables.

@satoryu
Copy link
Member Author

satoryu commented Dec 24, 2019

ping @chrahunt

@satoryu satoryu merged commit 03216e3 into ruby-docx:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant