Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported ruby versions #78

Merged
merged 3 commits into from
Jan 6, 2020
Merged

Conversation

satoryu
Copy link
Member

@satoryu satoryu commented Dec 30, 2019

ruby 2.7.0 has been released last week 🎉
This project has not specified supported ruby versions.

This PR provides changes on .travis.yml and the gemspec file to specify this gem supports 2.4.x or newer and drops 2.3(its EOR has come).

@satoryu satoryu requested a review from chrahunt December 30, 2019 04:35
docx.gemspec Outdated
@@ -11,6 +11,7 @@ Gem::Specification.new do |s|
s.email = ['chrahunt@gmail.com']
s.homepage = 'https://github.com/chrahunt/docx'
s.files = Dir["README.md", "LICENSE.md", "lib/**/*.rb"]
s.required_ruby_version = '>= 2.4.6'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify only 0 as micro version, like so: >= 2.4.0. This prevents issues for people using Rubies installed by OS package managers (rpm, deb, etc).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mvz ! I fixed.

@satoryu satoryu merged commit 1b017e1 into master Jan 6, 2020
@satoryu satoryu deleted the update_supported_ruby_versions branch January 6, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants