Subclass documentation #121 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. Please update CHANGELOG and squash the commits. |
|
Thank you for reminding me. On Mon, Apr 13, 2015 at 1:29 AM, Daniel Doubrovkine (dB.) @dblockdotorg <
|
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| * [#114](https://github.com/intridea/grape-entity/pull/114): Added 'only' option that selects which attributes should be returned - [@estevaoam](https://github.com/estevaoam). | |||
| * [#115](https://github.com/intridea/grape-entity/pull/115): Allowing 'root' to be inherited from parent to child entities - [@guidoprincess](https://github.com/guidoprincess). | |||
| * [#121](https://github.com/intridea/grape-entity/pull/122): Sublcassed Entity#documentation properly handles unexposed params. - [@dan-corneanu](https://github.com/dan-corneanu) | |||
There was a problem hiding this comment.
The period goes at the end, not after params :)
|
Can you please squash these and correct the super minor thing in CHANGELOG? Thanks. |
|
squashed |
|
Merging, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for issue
Subclasses keep the parent's .documentation? #121
Currently each Entity keeps track of its own exposures in a class object instance variable. A new entity class makes a copy of it's parent exposures then goes on and modifies its own exposures (add or remove exposures).
For the moment, I think we can fix the documentation issue by simply removing the call to superclass.documentation.
In the future we might have to replace the class object instance variable (which is a simple hash at the moment) with something more elaborate (like a chained filter or something) to handle the child - parent relationship better. Ex. what happens if we add some more exposures to the parent entity after we defined the child entity? I think that the child entity will not catch that extra exposure.
Please review this pull request and let me know what you think.