Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: reset @using_class memoization on .setup #202

Merged
merged 1 commit into from
Jan 28, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
============

* Your contribution here.
* [#202](https://github.com/ruby-grape/grape-entity/pull/202): Fix: Reset `@using_class` memoization on `.setup` - [@rngtng](https://github.com/rngtng).

0.5.0 (2015-12-07)
==================
Expand Down
1 change: 1 addition & 0 deletions lib/grape_entity/exposure/represent_exposure.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ class RepresentExposure < Base
attr_reader :using_class_name, :subexposure

def setup(using_class_name, subexposure)
@using_class = nil
@using_class_name = using_class_name
@subexposure = subexposure
end
Expand Down
30 changes: 30 additions & 0 deletions spec/grape_entity/exposure/represent_exposure_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
require 'spec_helper'

describe Grape::Entity::Exposure::RepresentExposure do
subject(:exposure) { described_class.new(:foo, {}, {}, double, double) }

describe '#setup' do
subject { exposure.setup(using_class_name, subexposure) }

let(:using_class_name) { double(:using_class_name) }
let(:subexposure) { double(:subexposure) }

it 'sets using_class_name' do
expect { subject }.to change { exposure.using_class_name }.to(using_class_name)
end

it 'sets subexposure' do
expect { subject }.to change { exposure.subexposure }.to(subexposure)
end

context 'when using_class is set' do
before do
exposure.using_class
end

it 'resets using_class' do
expect { subject }.to change { exposure.using_class }
end
end
end
end