fix-serializable-hash-option

[sbatykov]

No description provided.

[dblock]

I am not sure what this does, it needs specs and a CHANGELOG entry please?

[sbatykov]

       def serializable_value(entity, options)
          partial_output = valid_value(entity, options)
          if partial_output.respond_to?(:serializable_hash)
            partial_output.serializable_hash
          elsif partial_output.is_a?(Array) && partial_output.all? { |o| o.respond_to?(:serializable_hash) }
            partial_output.map(&:serializable_hash)
          elsif partial_output.is_a?(Hash)
            partial_output.each do |key, value|
              partial_output[key] = value.serializable_hash if value.respond_to?(:serializable_hash)
            end
          else
            partial_output
          end
        end

Options already pass to output result in partial_output = valid_value(entity, options) and can be modified self-own way.
When call partial_output.serializable_hash(option) options will be merged.

Also all others else branch, didn't pass options to serializable_hash. May be it's old code.

I will add CHANGLOG entry.

[dblock]

Ok makes sense. You need to write a test that shows a failure without this fix, please.

[sbatykov]

commit test and change log

[dblock]

These are global scope. Can you declare them with let(:address) { Class.new(...) } please?

[dblock]

Thanks. See my comments on tests. Squash your commits too please if you can.

[dblock]

Merged.