Let the OutputBuilder be the Hash as well #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagebomb
force-pushed
the
fix-grape-master-falling-specs
branch
from
7d7797b
to
d96ef92
Compare
|
The build is toast, but I don't think it's your fault. If you don't mind taking a look though please. |
sagebomb
force-pushed
the
fix-grape-master-falling-specs
branch
from
d96ef92
to
1b791b2
Compare
|
MRI 2.3: ✅ |
|
Yes please |
sagebomb
force-pushed
the
fix-grape-master-falling-specs
branch
2 times, most recently
from
aa915f7
to
e1624d9
Compare
|
The same problem with |
| @@ -4,6 +4,7 @@ | |||
| * [#215](https://github.com/ruby-grape/grape-entity/pull/217): Fix: `#delegate_attribute` no longer delegates to methods included with `Kernel` - [@maltoe](https://github.com/maltoe). | |||
| * [#219](https://github.com/ruby-grape/grape-entity/pull/219): Fix: double pass options in serializable_hash - [@sbatykov](https://github.com/sbatykov). | |||
| * [#226](https://github.com/ruby-grape/grape-entity/pull/226): Add fetch method to fetch from opts_hash - [@alanjcfs](https://github.com/alanjcfs). | |||
| * [#232](https://github.com/ruby-grape/grape-entity/pull/232): Fix: grape tests are green [#213](https://github.com/ruby-grape/grape-entity/issues/213) - [@avyy](https://github.com/avyy). | |||
There was a problem hiding this comment.
This isn't material for users, so remove it.
There was a problem hiding this comment.
However, the kind_of change is relevant, so you should say something to that regard.
|
@dblock check last changes pls |
…class, specify rack, json and active_support version for supporting old rubies
sagebomb
force-pushed
the
fix-grape-master-falling-specs
branch
from
8e11a2c
to
a6c8e85
Compare
|
Merging, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#213
Hi everyone
The problem that we've changed the
Hashoutput to theOutputBuilderone (see #204) . Even though anOutputBuilderinstance delegates everything to itsoutputobject (which is aHash) - it returnsfalsewhen we do this:.is_a?(Hash)on aOutputBuilderinstance.is_a?method is not delegated. And grape errors formatters expect to get aHashinstance fromEntityafter representation, notOutputBuilderone.I checked grape master branch and my grape-entity branch tests. Everything should be fine.