Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop cleanup #264

Merged
merged 7 commits into from
Apr 5, 2017
Merged

Rubocop cleanup #264

merged 7 commits into from
Apr 5, 2017

Conversation

james2m
Copy link
Contributor

@james2m james2m commented Apr 5, 2017

Adds a Rubocop config for 0.48.1 based on the config from grape, and update the todo list for the existing offences. I don't have time to fix all those issues so I suggest tackling the todo should be a separate PR.

Copy link
Member

@LeFnord LeFnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks … please can you also adapt the rubocop version in the gem spec, thanks

.rubocop.yml Outdated
@@ -1,6 +1,30 @@
AllCops:
TargetRubyVersion: 2.1
Copy link
Member

@LeFnord LeFnord Apr 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change it to 2.4, maybe also in the grape

@coveralls
Copy link

coveralls commented Apr 5, 2017

Coverage Status

Coverage remained the same at 92.788% when pulling 2aef229 on james2m:rubocop-cleanup into 17b0c6c on ruby-grape:master.

@LeFnord
Copy link
Member

LeFnord commented Apr 5, 2017

please run bundle exec rubocop -a to fix the frozen string luteral stuff, thanks

@coveralls
Copy link

coveralls commented Apr 5, 2017

Coverage Status

Coverage remained the same at 92.788% when pulling d8d895d on james2m:rubocop-cleanup into 17b0c6c on ruby-grape:master.

@LeFnord
Copy link
Member

LeFnord commented Apr 5, 2017

thanks @james2m

@LeFnord LeFnord merged commit 0930f60 into ruby-grape:master Apr 5, 2017
@dblock
Copy link
Member

dblock commented Apr 5, 2017

FWIW I generally just stick to rubocop -a ; rubocop --auto-gen-config. It's easier to think about.

@james2m james2m deleted the rubocop-cleanup branch April 7, 2017 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants