Loosen the activesupport dependency #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
anakinj
force-pushed
the
loosen-activesupport-dependency
branch
from
41b8d2c
to
93cc316
Compare
LeFnord
requested changes
Apr 18, 2017
grape-entity.gemspec
Outdated
| @@ -19,7 +19,7 @@ Gem::Specification.new do |s| | |||
| s.rubyforge_project = 'grape-entity' | |||
|
|
|||
| s.add_runtime_dependency 'multi_json', '>= 1.3.2' | |||
| s.add_runtime_dependency 'activesupport', '>= 5.0.0' | |||
| s.add_runtime_dependency 'activesupport' | |||
There was a problem hiding this comment.
please change instead to: > 4, else it would fail this spec./spec/grape_entity/hash_spec.rb:6 # Grape::Entity except option for nested entity) with < 4
anakinj
force-pushed
the
loosen-activesupport-dependency
branch
from
93cc316
to
8a1afa6
Compare
LeFnord
approved these changes
Apr 18, 2017
anakinj
force-pushed
the
loosen-activesupport-dependency
branch
from
8a1afa6
to
2d1019a
Compare
|
I still changed this version to >=4.0.0 to be more schematically pretty, and allow the 4.0.0 version of activesupport :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.