Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruby 2.7 deprecation warning #338

Merged
merged 2 commits into from
Sep 5, 2020

Conversation

begotten63
Copy link
Contributor

Fix warning with keyword arguments:

/Users/begotten63/.rvm/gems/ruby-2.7.1/gems/grape-entity-0.8.1/lib/grape_entity/entity.rb:540: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

/Users/begotten63/.rvm/gems/ruby-2.7.1/gems/grape-entity-0.8.1/lib/grape_entity/delegator/hash_object.rb:7: warning: The called method 'delegate' is defined here

@grape-bot
Copy link

grape-bot commented Sep 4, 2020

2 Warnings
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#338](https://github.com/ruby-grape/grape-entity/pull/338): Fix ruby 2.7 deprecation warning - [@begotten63](https://github.com/begotten63).

Generated by 🚫 danger

@grape-bot
Copy link

grape-bot commented Sep 4, 2020

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@coveralls
Copy link

coveralls commented Sep 4, 2020

Coverage Status

Coverage remained the same at 95.887% when pulling 233e0f4 on begotten63:fix-2.7.1-deprication-warning into 0a8cbb9 on ruby-grape:master.

…parameters is deprecated; maybe ** should be added to the call)
@LeFnord
Copy link
Member

LeFnord commented Sep 5, 2020

thanks @begotten63

@LeFnord LeFnord merged commit 13e80ba into ruby-grape:master Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants