Specify the class in String in using option
#50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -635,8 +635,23 @@ def timestamp(date) | |||
| end | |||
|
|
|||
| context 'child representations' do | |||
| it 'disables root key name for child representations' do | |||
| it 'should correct find the class constant specified in string' do | |||
There was a problem hiding this comment.
Change to present it "corrects ...".
|
Please update the README and the CHANGELOG. The build failed because of a Rubocop offense. Please do these via |
|
@dblock Updated. |
| @@ -13,6 +13,11 @@ Next Release | |||
| * [#47](https://github.com/intridea/grape-entity/pull/47): Support nested exposures - [@wyattisimo](https://github.com/wyattisimo). | |||
| * Your contribution here. | |||
|
|
|||
|
|
|||
| 0.4.0 (2014-01-13) | |||
There was a problem hiding this comment.
This should go above, as a line for "next release", please.
|
Merged via 856c9d0. |
|
Thanks @dblock , sorry for all the bothering I've brought. Just started to do some open source. I will be better next time. |
|
You did totally great! Thanks for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now supports specify the class constant in String in
usingoption in full path.Fix for issue: #46