Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpenStruct serializing #91

Merged
merged 1 commit into from
Sep 11, 2014
Merged

Fix OpenStruct serializing #91

merged 1 commit into from
Sep 11, 2014

Conversation

etehtsea
Copy link
Contributor

@dblock
Copy link
Member

dblock commented Sep 11, 2014

I like it. You should update CHANGELOG, too, please.

@etehtsea
Copy link
Contributor Author

@dblock done.

@dblock
Copy link
Member

dblock commented Sep 11, 2014

@dspaeth-faber Take a look at this PR too pls. Just want to make sure I am not missing anything. Thx.

@dspaeth-faber
Copy link
Contributor

👍 looks good

dblock added a commit that referenced this pull request Sep 11, 2014
@dblock
Merge pull request #91 from etehtsea/fix-arg-error
d56122f 
Fix OpenStruct serializing
@dblock dblock merged commit d56122f into ruby-grape:master Sep 11, 2014
@dblock
Copy link
Member

dblock commented Sep 11, 2014

Merged, thanks.

@aj0strow
Copy link
Contributor

@etehtsea thank you. That ArgumentError needed to peace.

@etehtsea etehtsea deleted the fix-arg-error branch September 19, 2014 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@etehtsea @dblock @dspaeth-faber @aj0strow