Keep gem in fit

[numbata]

• Bump ruby version for the danger workflow step up to 3.0.
• Fix rubocop offense

[numbata]

It looks like the ruby-grape-danger should bump it's own dependency on the danger gem. Because of that:

        rest_inline_violations = submit_inline_comments!({
          danger_id: danger_id,
          previous_violations: previous_violations
        }.merge(**inline_violations))

The "new" Ruby version sees this explicitly defined hash as a position argument, not as part of keyword arguments. But the definition of the submit_inline_comments method expects only keyword arguments and no any positional.

 def submit_inline_comments!(warnings: [], errors: [], messages: [], markdowns: [], previous_violations: [], danger_id: "danger")

Of course I can also create a PR for the ruby-grape-danger gem, but is it worth it? Seems like other gems in the grape-* family just get rid of this workflow step.

@mscrivo wdyt?

[mscrivo]

It looks like the ruby-grape-danger should bump it's own dependency on the danger gem. Because of that:

        rest_inline_violations = submit_inline_comments!({
          danger_id: danger_id,
          previous_violations: previous_violations
        }.merge(**inline_violations))

The "new" Ruby version sees this explicitly defined hash as a position argument, not as part of keyword arguments. But the definition of the submit_inline_comments method expects only keyword arguments and no any positional.

 def submit_inline_comments!(warnings: [], errors: [], messages: [], markdowns: [], previous_violations: [], danger_id: "danger")

Of course I can also create a PR for the ruby-grape-danger gem, but is it worth it? Seems like other gems in the grape-* family just get rid of this workflow step.

@mscrivo wdyt?

yeah I remember running into this before, which is why I set the ruby version back to 2.7 for danger. I think it's best to just to do that. Seems grape still runs danger and it uses 2.7 as well: https://github.com/ruby-grape/grape/actions/runs/7609193746/job/20719891863?pr=2414

[numbata]

The problem here is that the grape-swagger gem requires ruby version 3.x. And that's why the grape-swagger-entity is forced by danger to use that version as well. Even though it is not so necessary.

While the grape gem itself has no such dependencies and free to choose which Ruby version to use.

[mscrivo]

@dblock any plans to make danger Ruby 3.x compatible? Any suggestions on what we should do here?

[numbata]

The original'danger' is already compatible. It's just grape's danger locked on outdated version of it.

[mscrivo]

Fixed in #66

[numbata]

Thank for such active support! 👍

fyi: my attempt (in early version state) to achieve ruby 3.x support, but keep the ruby 2.x support.
ruby-grape/danger@master...numbata:ruby-grape-danger:bump_dependencies