Update to work with Grape 2.0 #911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @dblock not sure if you get notified for all PRs |
LeFnord
reviewed
Nov 13, 2023
| run: | | ||
| bundle update | ||
| bundle exec rspec | ||
| - name: Check out branch |
There was a problem hiding this comment.
any reason why this change?
it isn't related nor needed
| #### Fixes | ||
|
|
||
| * [#903](https://github.com/ruby-grape/grape-swagger/pull/903): Accept `example` documentation parameter for arrays - [@VladMomotov](https://github.com/VladMomotov) | ||
| * [#911](https://github.com/ruby-grape/grape-swagger/pull/911): Fix compatibility with Grape 2.0.0 - [@mscrivo](https://github.com/mscrivo) |
There was a problem hiding this comment.
please move it to the feature section
| @@ -15,7 +15,7 @@ Gem::Specification.new do |s| | |||
| s.metadata['rubygems_mfa_required'] = 'true' | |||
|
|
|||
| s.required_ruby_version = '>= 2.7' | |||
| s.add_runtime_dependency 'grape', '~> 1.3' | |||
| s.add_runtime_dependency 'grape', ['>= 1.3.0', '< 3.0.0'] | |||
| @@ -1,5 +1,5 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module GrapeSwagger | |||
| VERSION = '1.6.1' | |||
| VERSION = '1.6.2' | |||
|
and please no hurry next time, some people have to work for money |
|
and yeah … there is a PR for it, see #910 |
|
I did not see that PR, my apologies. I'll close this once that gets merged. |
|
closing it in favour of #910 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per title, bumps to version 1.6.2 in prep for a release.