-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Readme with Mounting Multiple Versions #1349
Conversation
FYI I did that on master so we can have a build in #1353. |
Great, thank you, let me pull it and merge it |
@dblock : please check README and let me know for further improvements. Thanks |
It doesn't quite read as documentation, more like a blog post or example. Specifically, I'm not in love with It's a good start though. I can take a stab at this later or you can try iterating on it. |
@@ -25,6 +25,7 @@ | |||
- [Header](#header) | |||
- [Accept-Version Header](#accept-version-header) | |||
- [Param](#param) | |||
- [Mounting Multiple Versions](#mounting-multiple-versions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this belongs in Mounting more than Versioning, because Versioning is all about kinds of versioning schemes.
I appreciate the effort here, but I think it's a bit far from reading like a doc and wasn't active after my comments. I'll close it for now, please feel free to reopen with an update. |
improve documentation following (http://code.dblock.org/2013/07/19/evolving-apis-using-grape-api-versioning.html)