Accept header strict

[rodzyn]

Hey,

I was a bit confused about header versioning (for example #133) and I thought maybe it should be more strict.
When no Accept is passed like

curl http://localhost:9292/hello

I had default value */* of accept header, so condition:

(accept.nil? || accept.empty?)

was never true.

BTW.
Test case covered only this scenario:

curl -H "Accept: " http://localhost:9292/hello

I've added few more tests.

[dblock]

Small note, if ... && options[:versions] is redundant with the if above it. This block is executed within the same if already.

[dblock]

This is definitely on the right path, but I think we shouldn't be eating an invalid accept header and issuing a 404. Shouldn't there be a 400 failure in this case? If so then I would split the condition and rewrite incorrect_header? as is_accept_header_valid? (adding the accept part cause incorrect_header? is too generic and misleading for a name).

[dblock]

The RFC says this:

If no Accept header field is present, then it is assumed that the client accepts all media types. If an Accept header field is present, and if the server cannot send a response which is acceptable according to the combined Accept field value, then the server SHOULD send a 406 (not acceptable) response.

So I think the 404 is wrong. It should be a 406 both ways.

[rodzyn]

Hi, thanks for comments I definitely agree with your thoughts. I've added some changes. What do you think?

[dblock]

Very good. I'm merging this.