Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust test expectations to conform to rack 3 #2346

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Adjust test expectations to conform to rack 3 #2346

merged 2 commits into from
Aug 21, 2023
+16 −11

Conversation

kbarrette
Copy link
Contributor

As suggested in #2298, here's a PR that adjusts test expectations to conform to rack 3

@grape-bot
Copy link

grape-bot commented Aug 21, 2023 •
edited
Loading

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

@kbarrette kbarrette mentioned this pull request Aug 21, 2023
Closed
dblock
dblock approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@dblock dblock merged commit df3b3c8 into ruby-grape:master Aug 21, 2023
27 checks passed
@kbarrette kbarrette deleted the kbarrette/rack-3 branch August 21, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kbarrette @grape-bot @dblock