Fix instructions in README.markdown regarding Rails 3.x reloading endpoint per request #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original instructions didn't seem to work on Rails 3.2.x. Followed instructions on wiki (https://github.com/intridea/grape/wiki/Reload-Grape-API-on-every-request-in-Rails) and it works without issue. In the original instructions, I could only get grape to reload my endpoint once. Using this submitted approach looks also looks like a standard way to hook reloading into any inbound Rails request.
|
I'll look into this and test the changes on another app that uses the old code - seems like there're some small variations that make a big difference and depend on the app you have - we have to provide something generic. |
|
I made some small adjustments around variable naming. Please check it. Thanks for updating, this works as well and is much shorter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original instructions didn't work for me on Rails 3.2.11. I used the instructions on the wiki and it works fine (https://github.com/intridea/grape/wiki/Reload-Grape-API-on-every-request-in-Rails).
Edited the README.markdown file to correct this since these instructions caused me to waste time trying to figure out how to get reloading working.