A fix for failing CI against edge Rails #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because Rails 7.1 changed its implementation to hold the `@data` ivar as a marshalled String
|
|
radar
approved these changes
Jun 2, 2023
radar
approved these changes
Jun 2, 2023
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a fix for the edge Rails CI failure.
There's a test code directly accessing a cached instance variable inside Active Support MemoryStore object, but since Rails 7.1 changed its implementation to hold the
@dataivar as a marshalled String, the test now fails on edge Rails.This patch fixes the failure by properly calling publicly accessible API.