Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose thread so it can be joined #22

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

jlaffaye
Copy link

@jlaffaye jlaffaye commented Jul 26, 2023

I have a use case where I dont have to write anything to the websocket but just have to read from it.
Currently, I have to wait with

sleep(0.1) until ws.closed?

With the suggested change, it can be replaced with

ws.thread.join

@unasuke
Copy link
Collaborator

unasuke commented Jul 28, 2023

@jlaffaye Sorry for late. Could you rebase from the latest master branch?

@unasuke unasuke merged commit c4d4d01 into ruby-jp:master Aug 4, 2023
5 checks passed
@unasuke
Copy link
Collaborator

unasuke commented Aug 4, 2023

@jlaffaye Thank you!

@unasuke
Copy link
Collaborator

unasuke commented Aug 4, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants