Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise errors from WebSocket gem #25

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

jlaffaye
Copy link

@jlaffaye jlaffaye commented Aug 4, 2023

Without this, the library hangs forever when the server returns an HTTP error.
With this change, we get a WebSocket::Error::Handshake::InvalidStatusCode exception.

@unasuke unasuke merged commit 281a61c into ruby-jp:master Aug 9, 2023
5 checks passed
@unasuke
Copy link
Collaborator

unasuke commented Aug 9, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants