Set operation result if LDAP server is not accessible #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ldap_client = Net::LDAP.new(host: '127.0.0.1', port: 12345) | ||
|
|
||
| assert_raise Net::LDAP::ConnectionRefusedError do |
There was a problem hiding this comment.
I'm not not a reqular user of minitest. If there's a better approach to handle errors, I'm open to fix this. begin; rescue; end didn't work for that use case.
|
@padde Again FYI |
|
Thanks for this PR. I've been rescuing the errors and assuming the result code is invalid, but this avoids surprising and unexpected behavior. From RFC 4511: Seems like a good fit. |
jch
added a commit
that referenced
this pull request
Nov 6, 2015
…t_connection_refused Set operation result if LDAP server is not accessible
|
Cool. Thanks a lot! Can you a release 0.12.1 with this fix? This would help me getting a system live. :-) |
Merged
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Dec 12, 2015
=== Net::LDAP 0.12.1
* Whitespace formatting cleanup
{#236}[ruby-ldap/ruby-net-ldap#236]
* Set operation result if LDAP server is not accessible
{#232}[ruby-ldap/ruby-net-ldap#232]
=== Net::LDAP 0.12.0
* DRY up connection handling logic
{#224}[ruby-ldap/ruby-net-ldap#224]
* Define auth adapters
{#226}[ruby-ldap/ruby-net-ldap#226]
* add slash to attribute value filter
{#225}[ruby-ldap/ruby-net-ldap#225]
* Add the ability to provide a list of hosts for a connection
{#223}[ruby-ldap/ruby-net-ldap#223]
* Specify the port of LDAP server by giving INTEGRATION_PORT
{#221}[ruby-ldap/ruby-net-ldap#221]
* Correctly set BerIdentifiedString values to UTF-8
{#212}[ruby-ldap/ruby-net-ldap#212]
* Raise Net::LDAP::ConnectionRefusedError when new connection is
refused. {#213}[ruby-ldap/ruby-net-ldap#213]
* obscure auth password upon #inspect, added test, closes #216
{#217}[ruby-ldap/ruby-net-ldap#217]
* Fixing incorrect error class name
{#207}[ruby-ldap/ruby-net-ldap#207]
* Travis update {#205}[ruby-ldap/ruby-net-ldap#205]
* Remove obsolete rbx-19mode from Travis
{#204}[ruby-ldap/ruby-net-ldap#204]
* mv "sudo" from script/install-openldap to .travis.yml
{#199}[ruby-ldap/ruby-net-ldap#199]
* Remove meaningless shebang
{#200}[ruby-ldap/ruby-net-ldap#200]
* Fix Travis CI build
{#202}[ruby-ldap/ruby-net-ldap#202]
* README.rdoc: fix travis link
{#195}[ruby-ldap/ruby-net-ldap#195]
astratto
pushed a commit
to astratto/ruby-net-ldap
that referenced
this pull request
Dec 18, 2015
…ion_result_connection_refused Set operation result if LDAP server is not accessible
This was referenced Oct 14, 2019
This was referenced Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #231.