Reduce message batches in requeue and mv commands #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces the `rerun` parameter with a separate method that just handles messages post-normalization, just to improve readability.
Since it's possible now to send a batch with fewer messages than `messages_per_batch`, the parameter is really just an upper bound for the number of messages to put into any single batch.
The previous algorithm computed the size of a batch of messages using the Ruby literal representation of the messages, which overestimates the true size of the messages as SQS computes it. While overestimating is relatively benign, it does mean that we can end up making more SQS API calls than necessary.
The previous algorithm considered each `max_batch_size`-sized slice of the messages in order. For each slice, it'd subdivide the slice until the batches were small enough to send. To minimize the number of batches we send, however, it makes more sense to take as many messages as we can from the beginning of the list of messages, and just do that repeatedly until we've sent them all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #664