-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unescapeHTML #48
Fix unescapeHTML #48
Conversation
This looks like a reasonable problem to solve. Do you mind adding an initial commit with failing test cases? |
Done. |
It appears the added test cases make JRuby fail as well. It is now fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Looks good to me, but I think @nobu is the CGI maintainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also looks fine to me.
The behavior of
optimized_unescape_html
is inconsistent with Ruby's implementation ofunescapeHTML
for some edge cases, such as&a>
, where Ruby's implementation gives&a>
butoptimized_unescape_html
leaves it unchanged because the second&
is skipped aftera
is parsed.