Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jruby support #9

Merged
merged 1 commit into from
Jun 3, 2022
Merged

jruby support #9

merged 1 commit into from
Jun 3, 2022

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Sep 23, 2021

this PR imports a Java version of the CGI library, see jruby/jruby#6682

JRuby contribs
https://github.com/jruby/jruby/commits/master/core/src/main/java/org/jruby/ext/cgi/escape/CGIEscape.java

Charles Oliver Nutter (@headius)
Thomas Enebo (@enebo)

could you grant permission to relicense the code to BSD 2-Clause "Simplified" License ?

@headius
Copy link

headius commented Sep 23, 2021

I consent to having my contributions to the JRuby native cgi/escape library relicensed under the terms of the BSD 2-Clause License and the Ruby license.

@enebo
Copy link

enebo commented Sep 30, 2021

I consent to having my contributions to the JRuby native cgi/escape library relicensed under the terms of the BSD 2-Clause License and the Ruby license.

cgi.gemspec Outdated Show resolved Hide resolved
@ahorek ahorek mentioned this pull request Oct 29, 2021
@ahorek ahorek force-pushed the jruby_support branch 6 times, most recently from f140689 to 1f2bc5a Compare November 28, 2021 21:16
@headius
Copy link

headius commented Dec 7, 2021

How are we looking here?

@hsbt
Copy link
Member

hsbt commented Dec 13, 2021

@headius @ahorek Basically, I'm +1 to merge this. But I don't have a time to coordinate the directory structure same as ruby/digest#25

@ahorek
Copy link
Contributor Author

ahorek commented Mar 29, 2022

@hsbt I rebased the PR against the current master, please let me know if there's any misplaced file, but the directory structure should match our previous discussion about the digest gem. In short, all JRuby-specific files are separated to cgi/ext/java/* and they're not included in the CRuby version of the gem.

@hsbt hsbt merged commit fc56707 into ruby:master Jun 3, 2022
@headius
Copy link

headius commented Sep 22, 2022

@hsbt I don't think this has made it into a release yet... can we make that happen?

@hsbt
Copy link
Member

hsbt commented Sep 22, 2022

@headius Oh sorry. I released v0.3.3 with these changes.

@headius
Copy link

headius commented Sep 22, 2022

@hsbt Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants