Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Enhanced RDoc #62

Merged
merged 4 commits into from
Jul 11, 2022
Merged

[DOC] Enhanced RDoc #62

merged 4 commits into from
Jul 11, 2022

Conversation

BurdetteLamar
Copy link
Member

Minor edits to 11 methods' documentation.

ext/date/date_core.c Outdated Show resolved Hide resolved
ext/date/date_core.c Outdated Show resolved Hide resolved
ext/date/date_core.c Outdated Show resolved Hide resolved
*
* Returns the Julian start date for calendar reform;
* if not an infinity, the returned value is suitable
* for passing to Date#jd(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo:

Suggested change
* for passing to Date#jd(
* for passing to Date#jd:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

* Date.new(2001, 2, 3, Date::GREGORIAN).start # => -Infinity
* Date.new(2001, 2, 3, Date::JULIAN).start # => Infinity
*
* The returned value is sui
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's some leftover text here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BurdetteLamar BurdetteLamar merged commit 00bb7f6 into ruby:master Jul 11, 2022
matzbot pushed a commit to ruby/ruby that referenced this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants