Fix Time#to_datetime before calendar reform #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time is always in the proleptic Gregorian calendar. Also DateTime#to_time should convert to the Gregorian calendar first, before extracting its components. https://bugs.ruby-lang.org/issues/18946#change-98527
eileencodes
added a commit
to rails/rails
that referenced
this pull request
Aug 18, 2022
In Ruby trunk date changed to use the gregorian calendar in ruby/date#73. This had the result that dates not in the gregorian calendar can't be compared to times not in the gregorian calendar. Since this test isn't testing datetime comparison but rather that bc timestamps can be stored in the database, we can compare with `Time.new(0) - 1.week` rather than `Date.new(0) - 1.week`. I think this might be a bug in Ruby but I'm not sure there's a great fix. For now however, let's get this test passing.
eileencodes
added a commit
to rails/rails
that referenced
this pull request
Dec 16, 2022
In Ruby trunk date changed to use the gregorian calendar in ruby/date#73. This had the result that dates not in the gregorian calendar can't be compared to times not in the gregorian calendar. Since this test isn't testing datetime comparison but rather that bc timestamps can be stored in the database, we can compare with `Time.new(0) - 1.week` rather than `Date.new(0) - 1.week`. I think this might be a bug in Ruby but I'm not sure there's a great fix. For now however, let's get this test passing.
eileencodes
added a commit
to rails/rails
that referenced
this pull request
Jan 5, 2023
In Ruby trunk date changed to use the gregorian calendar in ruby/date#73. This had the result that dates not in the gregorian calendar can't be compared to times not in the gregorian calendar. Since this test isn't testing datetime comparison but rather that bc timestamps can be stored in the database, we can compare with `Time.new(0) - 1.week` rather than `Date.new(0) - 1.week`. I think this might be a bug in Ruby but I'm not sure there's a great fix. For now however, let's get this test passing.
eileencodes
added a commit
to rails/rails
that referenced
this pull request
Jan 5, 2023
In Ruby trunk date changed to use the gregorian calendar in ruby/date#73. This had the result that dates not in the gregorian calendar can't be compared to times not in the gregorian calendar. Since this test isn't testing datetime comparison but rather that bc timestamps can be stored in the database, we can compare with `Time.new(0) - 1.week` rather than `Date.new(0) - 1.week`. I think this might be a bug in Ruby but I'm not sure there's a great fix. For now however, let's get this test passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time is always in the proleptic Gregorian calendar.
Also DateTime#to_time should convert to the Gregorian calendar first, before extracting its components.
https://bugs.ruby-lang.org/issues/18946#change-98527