Fix flakey test "test_reponse_returns_correct_threads_info" #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjunior
referenced
this pull request
in powerhome/audiences
Apr 8, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [debug](https://github.com/ruby/debug) | `1.9.1` -> `1.9.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ruby/debug (debug)</summary> ### [`v1.9.2`](https://github.com/ruby/debug/releases/tag/v1.9.2) [Compare Source](https://github.com/ruby/debug/compare/v1.9.1...v1.9.2) #### What's Changed - config - Make irb_console toggleable with config update by [@​st0012](https://github.com/st0012) in [https://github.com/ruby/debug/pull/1057](https://github.com/ruby/debug/pull/1057) - internal - Stop assuming Array#each is written in C by [@​k0kubun](https://github.com/k0kubun) in [https://github.com/ruby/debug/pull/1061](https://github.com/ruby/debug/pull/1061) - Add `base64` gem to the dependencies by [@​y-yagi](https://github.com/y-yagi) in [https://github.com/ruby/debug/pull/1066](https://github.com/ruby/debug/pull/1066) - Support Ruby 3.4's new error message format by [@​hsbt](https://github.com/hsbt) in [https://github.com/ruby/debug/pull/1080](https://github.com/ruby/debug/pull/1080) - catch up ruby 3.4.0 error related changes by [@​ko1](https://github.com/ko1) in [https://github.com/ruby/debug/pull/1083](https://github.com/ruby/debug/pull/1083) - Fix syntax warnings by [@​casperisfine](https://github.com/casperisfine) in [https://github.com/ruby/debug/pull/1072](https://github.com/ruby/debug/pull/1072) - Drop base64 dependency by [@​Earlopain](https://github.com/Earlopain) in [https://github.com/ruby/debug/pull/1071](https://github.com/ruby/debug/pull/1071) - Fix ENOENT error when readline is not loaded by [@​lazyatom](https://github.com/lazyatom) in [https://github.com/ruby/debug/pull/1073](https://github.com/ruby/debug/pull/1073) - Remove and Restore irb configuration like irbrc while irb console tests by [@​hsbt](https://github.com/hsbt) in [https://github.com/ruby/debug/pull/1067](https://github.com/ruby/debug/pull/1067) - Use rb_iseqw_to_iseq to get iseq pointer by [@​peterzhu2118](https://github.com/peterzhu2118) in [https://github.com/ruby/debug/pull/1093](https://github.com/ruby/debug/pull/1093) - tests - Add Ruby 3.3 to CI matrix by [@​st0012](https://github.com/st0012) in [https://github.com/ruby/debug/pull/1058](https://github.com/ruby/debug/pull/1058) - Use ruby/actions workflow for ruby versions by [@​m-nakamura145](https://github.com/m-nakamura145) in [https://github.com/ruby/debug/pull/1065](https://github.com/ruby/debug/pull/1065) - Separate setup and execution steps in CI by [@​ono-max](https://github.com/ono-max) in [https://github.com/ruby/debug/pull/1088](https://github.com/ruby/debug/pull/1088) - Fix flakey test "test_reponse_returns_correct_threads_info" by [@​ono-max](https://github.com/ono-max) in [https://github.com/ruby/debug/pull/1089](https://github.com/ruby/debug/pull/1089) - Add Launchable in CI by [@​ono-max](https://github.com/ono-max) in [https://github.com/ruby/debug/pull/1090](https://github.com/ruby/debug/pull/1090) - doc - Correct the irb command's description by [@​st0012](https://github.com/st0012) in [https://github.com/ruby/debug/pull/1056](https://github.com/ruby/debug/pull/1056) - Fix prelude doc example to use curly braces by [@​adam12](https://github.com/adam12) in [https://github.com/ruby/debug/pull/1052](https://github.com/ruby/debug/pull/1052) - Mention IRB console in readme by [@​st0012](https://github.com/st0012) in [https://github.com/ruby/debug/pull/1092](https://github.com/ruby/debug/pull/1092) #### New Contributors - [@​Earlopain](https://github.com/Earlopain) made their first contribution in [https://github.com/ruby/debug/pull/1071](https://github.com/ruby/debug/pull/1071) - [@​lazyatom](https://github.com/lazyatom) made their first contribution in [https://github.com/ruby/debug/pull/1073](https://github.com/ruby/debug/pull/1073) - [@​m-nakamura145](https://github.com/m-nakamura145) made their first contribution in [https://github.com/ruby/debug/pull/1065](https://github.com/ruby/debug/pull/1065) **Full Changelog**: ruby/debug@v1.9.1...v1.9.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/powerhome/audiences). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the "test_response_returns_correct_threads_info" test failed with the following issue:
https://github.com/ruby/debug/actions/runs/7971483036/job/21761265508#step:4:24
https://github.com/ruby/debug/actions/runs/7971521581/job/21761395380#step:4:24
The program did not pause at the breakpoint when the assert_threads_result method was called. Therefore, it's necessary to ensure that the program pauses after the "req_continue" method is invoked. This PR addresses and resolves the issue.
The above things are reported by @ko1-san. I appreciate for his help.