Remove usage of IO internals. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
io-hide-implementation
branch
7 times, most recently
from
17e0d66 to
a87e421
Compare
ioquatix
force-pushed
the
io-hide-implementation
branch
from
a87e421 to
105f263
Compare
…ial header definitions * TruffleRuby imports headers from CRuby, notably rb_io_descriptor() but existing releases do not implement it yet. So before this change, we get: compiling ext/io/console/console.c ext/io/console/console.c:92:1: error: static declaration of 'rb_io_descriptor' follows non-static declaration rb_io_descriptor(VALUE io) truffleruby-dev/lib/cext/include/ruby/io.h:685:5: note: previous declaration is here int rb_io_descriptor(VALUE io);
ioquatix
force-pushed
the
io-hide-implementation
branch
2 times, most recently
from
5a1ad9c to
b45323b
Compare
eregon
force-pushed
the
io-hide-implementation
branch
from
b45323b to
06c38a6
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
May 29, 2023
(ruby/io-console#43) ruby/io-console@4b839a504f Co-authored-by: Benoit Daloze <eregontp@gmail.com>
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jun 1, 2023
noteflakes
added a commit
to digital-fabric/polyphony
that referenced
this pull request
Jun 1, 2023
Following the example in ruby/io-console#43. There are still a missing API for setting the fd (e.g. in `Backend_accept`).
ioquatix
added a commit
to ioquatix/ruby
that referenced
this pull request
Jun 1, 2023
This reverts commit 35da41b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ruby/ruby#6511 for more details.
cc @KJTsanaktsidis