Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--inf-ruby-mode semantics #68

Closed
dgutov opened this issue Jan 27, 2020 · 4 comments · Fixed by #907
Closed

--inf-ruby-mode semantics #68

dgutov opened this issue Jan 27, 2020 · 4 comments · Fixed by #907

Comments

@dgutov
Copy link
Contributor

dgutov commented Jan 27, 2020

Can we make it imply --nosingleline and --nomultiline, but not anything else?

In particular, we (the inf-ruby upstream) decided not to use it because it also disables continuation prompts. Currently inf-ruby uses --prompt default --noreadline instead.

But with newer features here that we can't use from Emacs, it would be helpful if --inf-ruby-mode was an option one could use to avoid version checks. In particular, if irb --inf-ruby-mode --prompt default was a valid usage in the new IRB.
@dgutov dgutov mentioned this issue Jan 27, 2020
Closed
@dgutov
Copy link
Contributor Author

dgutov commented Jul 14, 2020 •
edited
Loading

Anybody cares about Emacs support here?

@mkaschenko
Copy link

+1

@gcentauri
Copy link

i know its been 2 years since this opened, but i'd like to give it a +1.

maybe it has been addressed in newer versions of ruby, but at least with my local version of ruby 2.7.5, adding it to the command options causes irb to fail to return the next prompt until i type another newline. it seems like the --noreadline option is possibly causing an issue.

it does seem to work on Ruby 3 though, but for the Emacs integration it would be quite nice to depend on this flag as @dgutov suggests.

@gcentauri
Copy link

ah i see my particular issue was addressed here #127

fwiw, i'm interested in helping with further Emacs support if any effort goes this way

dgutov added a commit to dgutov/irb that referenced this issue Mar 22, 2024
@dgutov
Switch to StdioInputMethod when TERM is 'dumb'
f04a184 
This works around Reline's misbehavior on low-capability terminals,
such as when IRB is launched inside Emacs (ruby/reline#616).

It should also resolve ruby#68 and resolve ruby#113 which were filed out of
similar need.
@dgutov dgutov mentioned this issue Mar 22, 2024
Merged
tompng added a commit that referenced this issue May 1, 2024
@dgutov @tompng
Switch to StdioInputMethod when TERM is 'dumb' (#907)
241e061 
* Switch to StdioInputMethod when TERM is 'dumb'

This works around Reline's misbehavior on low-capability terminals,
such as when IRB is launched inside Emacs (ruby/reline#616).

It should also resolve #68 and resolve #113 which were filed out of
similar need.

* Add special env for testing

See discussion in #907.

---------

Co-authored-by: tomoya ishida <tomoyapenguin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to StdioInputMethod when TERM is 'dumb' dgutov/irb
3 participants
@mkaschenko @dgutov @gcentauri