Store method objects in constants #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
reviewed
Nov 20, 2024
lib/irb/completion.rb
Outdated
| end | ||
|
|
||
| def eval_instance_variables | ||
| ::Kernel.instance_method(:instance_variables).bind(eval("self")).call | ||
| KERNEL_INSTANCE_VARIABLES.bind(eval("self")).call |
There was a problem hiding this comment.
We can use bind_call(receiver) for the above three.
tompng
reviewed
Nov 20, 2024
lib/irb/completion.rb
Outdated
| end | ||
|
|
||
| def eval_global_variables | ||
| ::Kernel.instance_method(:global_variables).bind(eval("self")).call | ||
| KERNEL_GLOBAL_VARIABLES.bind(eval("self")).call |
There was a problem hiding this comment.
::Kernel.global_variables is better because this does not need to look into self
It probably won't speed up things significantly, but these are hot paths and we can save a few method calls per completion/input call.
st0012
force-pushed
the
store-methods-in-constants
branch
from
bda99c0 to
5bf7e6a
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 20, 2024
(ruby/irb#1033) It probably won't speed up things significantly, but these are hot paths and we can save a few method calls per completion/input call. ruby/irb@f1e25ec7ae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It probably won't speed up things significantly, but these are hot paths and we can save a few method calls per completion/input call.