Enable deprecation warnings when using -W or -w #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requested in Ruby Bug 17377
JunichiIto
reviewed
Dec 8, 2020
| @@ -140,7 +140,7 @@ def IRB.parse_opts(argv: ::ARGV) | |||
| when "1" | |||
| $VERBOSE = false | |||
| else | |||
| $VERBOSE = true | |||
| Warning[:deprecated] = $VERBOSE = true | |||
There was a problem hiding this comment.
Don't you need to consider to switch category?
$ ruby --help
-W[level=2|:category]
set warning level; 0=silence, 1=medium, 2=verbose
There was a problem hiding this comment.
I don't think considering it is required for this commit. I'm not against it, but it's significantly more involved in terms of implementation, and I'm not attempting to replicate all aspects of the behavior of ruby -W in this commit, only trying to address what I see as the most important issue. I'll leave it up to the irb maintainers whether replicating all behaviors of ruby -w and ruby -W for irb -w and and irb -W is worth the implementation cost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested in Ruby Bug 17377