Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase completion's test coverage and add some minor improvements #412

Merged
merged 6 commits into from
Oct 7, 2022

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Oct 6, 2022

Changes

  1. Add tests to cover primitive types' completion
  2. Group some completion tests together
  3. Evaluate completion candidates only when we really need them (usually when doc_namespace == false)
  4. Correct assert_equal's argument order in completion tests (I'll go through other tests in follow up PRs)
  5. Sort constant completion's candidates like Fixed sorting of variables and matched suggestions in completion #379 does

@st0012 st0012 changed the title Refactor completion Increate completion's test coverage and add some minor improvements Oct 6, 2022
@st0012 st0012 changed the title Increate completion's test coverage and add some minor improvements Increase completion's test coverage and add some minor improvements Oct 6, 2022
@st0012 st0012 force-pushed the refactor-completion branch from 00a8c69 to ee9b33c Compare October 6, 2022 15:55
@st0012
Copy link
Member Author

st0012 commented Oct 6, 2022

cc @peterzhu2118

@peterzhu2118 peterzhu2118 merged commit 3fca944 into ruby:master Oct 7, 2022
@st0012 st0012 deleted the refactor-completion branch October 7, 2022 19:30
@st0012
Copy link
Member Author

st0012 commented Oct 7, 2022

@peterzhu2118 thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants