Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary coloring support check #413

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Remove unnecessary coloring support check #413

merged 1 commit into from
Oct 17, 2022

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Oct 7, 2022

Since IRB requires Ruby 2.5+, we don't need to check if coloring is supported in tests.

@st0012 st0012 mentioned this pull request Oct 8, 2022
Merged
@st0012
Copy link
Member Author

st0012 commented Oct 11, 2022

cc @peterzhu2118

peterzhu2118
peterzhu2118 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@peterzhu2118 peterzhu2118 merged commit f6f2b80 into ruby:master Oct 17, 2022
@st0012 st0012 deleted the drop-unnecessary-version-checks branch October 18, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhu2118 peterzhu2118 peterzhu2118 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st0012 @peterzhu2118