Fix display_document params in noautocomplete mode

[tompng]

Fix destructuring completion params in display_document (only used in noautocomplete mode)

# Line 250
Reline.completion_proc = ->(target, preposing, postposing) {
  ...
  @completion_params = [preposing, target, postposing, bind]
  ...
}

# Line 296
def show_doc_dialog_proc
  doc_namespace = ->(matched) {
    preposing, _target, postposing, bind = @completion_params
    ...
  }
  ...
end

# Line 422
def display_document(matched, driver: nil)
  ...
  _target, preposing, postposing, bind = @completion_params
  # Should be `preposing, _target, postposing, bind = @completion_params`
  ...
end

This bug only affects irb --noautocomplete --type-completor because RegexpCompletor does not use preposing.

$ irb --noautocomplete --type-completor
(type 1.ti[TAB][TAB])
irb(main):001> 1.ti[TAB]
irb(main):001> 1.times[TAB]
(should show rdoc but nothing happens. this pull request fixes it)

[st0012]

Good catch 👍
Should we also add yamatanooroti tests for --noautocomplete cases?

[tompng]

It needs type-completor to test in rendering test.
Instead, I added arguments assertion in display_dialog test

[st0012]

I'd avoid mutating internal states for tests as they're bound with deep implementation details.
How about we extract the doc namespace logic to a method and share it between show_doc_dialog_proc and display_document? Since show_doc_dialog_proc is tested, we can also have the coverage on the logic.

diff --git a/lib/irb/input-method.rb b/lib/irb/input-method.rb
index b74974b..573b6da 100644
--- a/lib/irb/input-method.rb
+++ b/lib/irb/input-method.rb
@@ -291,11 +291,12 @@ module IRB
       @auto_indent_proc = block
     end
 
+    def retrieve_doc_namespace(matched)
+      preposing, _target, postposing, bind = @completion_params
+      @completor.doc_namespace(preposing, matched, postposing, bind: bind)
+    end
+
     def show_doc_dialog_proc
-      doc_namespace = ->(matched) {
-        preposing, _target, postposing, bind = @completion_params
-        @completor.doc_namespace(preposing, matched, postposing, bind: bind)
-      }
       ->() {
         dialog.trap_key = nil
         alt_d = [
@@ -311,7 +312,7 @@ module IRB
         cursor_pos_to_render, result, pointer, autocomplete_dialog = context.pop(4)
         return nil if result.nil? or pointer.nil? or pointer < 0
 
-        name = doc_namespace.call(result[pointer])
+        name = retrieve_doc_namespace(result[pointer])
         # Use first one because document dialog does not support multiple namespaces.
         name = name.first if name.is_a?(Array)
 
@@ -419,8 +420,7 @@ module IRB
         return
       end
 
-      _target, preposing, postposing, bind = @completion_params
-      namespace = @completor.doc_namespace(preposing, matched, postposing, bind: bind)
+      namespace = retrieve_doc_namespace(matched)
       return unless namespace
 
       driver ||= RDoc::RI::Driver.new

[tompng]

The suggested code looks better. Thanks👍
I've updated