Avoid completing empty input #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I don't really understand how this would change the dialog tests' result 🤔 |
|
It's reline's bug that pasting Changing |
The candidate list for empty input is all methods + all variables + all constants + all keywords. It's a long list that is not useful.
st0012
force-pushed
the
stop-completing-empty-input
branch
from
ea49a72 to
45e4d4e
Compare
|
Yep it works, thank you 🙌 |
tompng
approved these changes
Jan 3, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jan 3, 2024
(ruby/irb#832) The candidate list for empty input is all methods + all variables + all constants + all keywords. It's a long list that is not useful. ruby/irb@812dc2df7b
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The candidate list for empty input is all methods + all variables + all constants + all keywords. It's a long list that is not useful.