Add rubocop with a few basic styling rules #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
apply-basic-styles
branch
from
54ada6c to
066894f
Compare
|
Errors are caused by TruffleRuby suites and not related to the changes here. |
st0012
force-pushed
the
apply-basic-styles
branch
from
066894f to
2ff60ad
Compare
st0012
force-pushed
the
apply-basic-styles
branch
from
2ff60ad to
51e6665
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 1, 2024
(ruby/irb#849) * Use rubocop to enforce a few styling rules * Add a CI job for linting ruby/irb@4f60cd88bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I dislike excessive linting warnings/errors we sometimes experience in projects, I think having a tool to enforce some universally agreed styles is beneficial in the long term. So I want to start introducing a few very basic rubocop rules that has been widely followed in this codebase (see
.rubocop.yml).As we gradually adopt more rules, the CI job and our editor (through LSP servers like Ruby LSP) will make them easy to follow and enforce as well.