Support repeating debugger input by passing empty input to it #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
support-repeating-debugger-input
branch
2 times, most recently
from
d8f148d to
34c4cdc
Compare
tompng
reviewed
Feb 2, 2024
st0012
force-pushed
the
support-repeating-debugger-input
branch
2 times, most recently
from
c1c617d to
99b760e
Compare
tompng
approved these changes
Feb 16, 2024
Since `rdbg` accepts empty input to repeat the previous command, IRB should take empty input in `irb:rdbg` sessions and pass them to the debugger. Currently, IRB simply ignores empty input and does nothing. This commit creates `EmptyInput` to represent empty input so it can fit into the current IRB's input processing flow in `Irb#eval_input`.
st0012
force-pushed
the
support-repeating-debugger-input
branch
from
99b760e to
7e728a1
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 16, 2024
to it (ruby/irb#856) * Test IRB's behaviour with empty input * Handle empty input and pass it to debugger Since `rdbg` accepts empty input to repeat the previous command, IRB should take empty input in `irb:rdbg` sessions and pass them to the debugger. Currently, IRB simply ignores empty input and does nothing. This commit creates `EmptyInput` to represent empty input so it can fit into the current IRB's input processing flow in `Irb#eval_input`. ruby/irb@0e9db419be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When typing empty input in
rdbgsessions,debugrepeats the last repeatable input so users don't need to typestepornextrepeatedly. But currentlyirb:rdbgsession doesn't support this as IRB ignores empty input completely.This PR supports the behaviour by adding representation for empty input, and pass it to the debugger when in the
irb:rdbgsession. I also added a test to check the current empty input behaviour in normal IRB sessions is not changed.Closes ruby/debug#1063