Refactor eval_path and SourceFinder::Source
#870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the original caching logic for the `eval_path` method and makes it easier to understand.
tompng
approved these changes
Feb 13, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 13, 2024
(ruby/irb#870) * Assign `@eval_path` through `irb_path=` method This simplifies the original caching logic for the `eval_path` method and makes it easier to understand. * Refactor SourceFinder::Source ruby/irb@c63e4c4035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the
eval_pathmethod works great, I think it's not straightforward to understand and perhaps not easy to debug. So I want to try another approach: move the file path check to@irb_path's assignment.Another refactor is that I think
SourceFinder::Source.find_endcan simply be a private instance method ofSource.