-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error message assertions for Ruby 3.4 #874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruby/ruby#9605 changes both quotes and format for exception messages. So we need to update the assertions in the tests.
st0012
force-pushed
the
update-error-message-assertions
branch
from
February 15, 2024 13:32
ea1bef6
to
afd5f57
Compare
st0012
changed the title
Relax assertions on error message related tests
Update error message assertions for Ruby 3.4
Feb 15, 2024
The failure is caused by the Ruby head builds still pulling the version from Feb 13th 🤔 |
tompng
approved these changes
Feb 15, 2024
Test is failing now, but it will going to pass within few day delay. |
This change is failed with
|
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 19, 2024
(ruby/irb#874) #9605 changes both quotes and format for exception messages. So we need to update the assertions in the tests. ruby/irb@9359d4b51d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby/ruby#9605 changes both quotes and format for exception messages. So we need to update the assertions in the tests.