-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IRB::NotImplementedError #878
Conversation
68041e8
to
8cebeab
Compare
lib/irb/lc/error.rb
Outdated
@@ -13,8 +13,8 @@ def initialize(val) | |||
end | |||
end | |||
class NotImplementedError < StandardError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know IRB has a NotImplementedError
🤯
Should we remove this version and make the JA version simply inherit Ruby's NotImplementedError
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to leave it to reduce difference between locale and possibility of locale dependent bug.
Actually, I think we don't need a locale-friendly version of |
8cebeab
to
bce137f
Compare
Makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup 👍
NotImplementedError
is defined globally, and can be used asraise NotImplementedError
But inside IRB module,
raise NotImplementedError
raises ArgumentError.Remove
IRB::NotImplementedError
andIRB::OutputMethod::NotImplementedError
because we don't need it.