Restructure workspace management #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, workspace is an attribute of IRB::Context in most use cases. But when some workspace commands are used, like `pushws` or `popws`, a workspace will be created and used along side with the original workspace attribute. This complexity is not necessary and will prevent us from expanding multi-workspace support in the future. So this commit introduces a @workspace_stack ivar to IRB::Context so IRB can have a more natural way to manage workspaces.
st0012
force-pushed
the
restructure-workspace-management
branch
from
22eb776 to
fe33141
Compare
tompng
reviewed
Feb 28, 2024
tompng
reviewed
Feb 28, 2024
st0012
force-pushed
the
restructure-workspace-management
branch
2 times, most recently
from
c5531ae to
5ff1d38
Compare
st0012
commented
Feb 29, 2024
tompng
reviewed
Feb 29, 2024
st0012
force-pushed
the
restructure-workspace-management
branch
from
5ff1d38 to
8ea782d
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Mar 1, 2024
(ruby/irb#888) * Remove dead irb_level method * Restructure workspace management Currently, workspace is an attribute of IRB::Context in most use cases. But when some workspace commands are used, like `pushws` or `popws`, a workspace will be created and used along side with the original workspace attribute. This complexity is not necessary and will prevent us from expanding multi-workspace support in the future. So this commit introduces a @workspace_stack ivar to IRB::Context so IRB can have a more natural way to manage workspaces. * Fix pushws without args * Always display workspace stack after related commands are used ruby/irb@61560b99b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, workspace is an attribute of IRB::Context in most use cases. But when some workspace commands are used, like
pushwsorpopws, a workspace will be created and used along side with the original workspace attribute.This complexity is not necessary and will prevent us from expanding multi-workspace support in the future.
So this PR introduces a @workspace_stack ivar to IRB::Context so IRB can have a more natural way to manage workspaces.
Also,
workspaces,pushws, andpopwscommands now print the full workspaces stack, which should make the commands' usage easier to understand.