-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use markdown format for docs #890
Conversation
Out of curiosity, why the switch? |
I think markdown has basically become the universal format in writing technical content. For example, we use it to write README and contributing guides all the time. If we keep writing Ruby docs in another format, it means both the maintainers and the contributors need to learn or maintain this knowledge too, which is a huge cost to pay (for example, it makes me think twice before touching the docs). So without seeing a clear benefit of using the rdoc format, I think we should stop paying this additional cost and make the document easier to contribute to, at least to most devs. (As a reference, almost 2 years ago Ruby also changed its contributing doc from rdoc to markdown format, among other things (ruby/ruby#5899)) |
100% agree.
I also agree, 100%.
I remember seeing this PR, but I don't recall seeing that Markdown for source code documentation was also considered/encouraged in ruby/* projects, but I am presuming this is the maintainer's choice. Not worth getting into in this thread, but Ruby documentation is my least favourite part of Ruby currently, so any type of PR that seems to resolve some pain around using RDoc currently piques my interest. |
I'm +1 to convert this. But I'm not sure what is happened mixing md and rdoc format in FYI: I have a plan to extract |
2359991
to
5a50d04
Compare
5a50d04
to
091e541
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@st0012 I discussed this at DevMeeting 2024-03-14. No one against this proposal if there is no issue to mix rdoc and markdown formats. Go ahead this.
@hsbt Thanks for raising this in the dev meeting 🙌 |
(ruby/irb#890) * Convert irb.rb's document into markdown format * Hide should-be-private top-level methods from docs * Skip xmp.rb's docs * Declare lib/irb.rb's markup do it works in ruby/ruby too * Ignore docs folder ruby/irb@e9a175e06b
(ruby/irb#890) * Convert irb.rb's document into markdown format * Hide should-be-private top-level methods from docs * Skip xmp.rb's docs * Declare lib/irb.rb's markup do it works in ruby/ruby too * Ignore docs folder ruby/irb@e9a175e06b
I used Rails's rdoc-to-md script for the majority of the conversion, and then manually tweaked a few issues that I found.
2 additional changes:
rake rdoc
task is added to simplify the doc generation command.IRB.JobManager
from the generated docs.