Rescue from exceptions raised by #name #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irb might terminate if the class overwrites `name` and raise errors. This commit rescue irb from termination.
tompng
reviewed
Mar 12, 2024
| @@ -388,7 +388,7 @@ def retrieve_completion_data(input, bind:, doc_namespace:) | |||
|
|
|||
| if doc_namespace | |||
| rec_class = rec.is_a?(Module) ? rec : rec.class | |||
| "#{rec_class.name}#{sep}#{candidates.find{ |i| i == message }}" | |||
| "#{rec_class.name}#{sep}#{candidates.find{ |i| i == message }}" rescue nil | |||
There was a problem hiding this comment.
👍
I think there is one more class.name in Line 421 that needs rescue nil
irb(main):010> @foo = Foo.new
=> #<Foo:0x00000001236950b8>
irb(main):011> @f[press tab]
(irb):4:in `name': Abort! (StandardError)
There was a problem hiding this comment.
Oops! Fixed in 00b5a97
Thanks for the review!
tompng
approved these changes
Mar 14, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Mar 14, 2024
(ruby/irb#899) * Rescue from exceptions raised by #name Irb might terminate if the class overwrites `name` and raise errors. This commit rescue irb from termination. * fix for other unknown patterns ruby/irb@35b87cf893
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
(ruby/irb#899) * Rescue from exceptions raised by #name Irb might terminate if the class overwrites `name` and raise errors. This commit rescue irb from termination. * fix for other unknown patterns ruby/irb@35b87cf893
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
When using autocompletion, irb might terminate after pressing tab if the class overwrites
nameand makes it raise errors for some reason. This commit rescue irb from termination.In irb,
Foo.ba[press tab]will terminate the session.In rails 7.0,
ActiveSupport::TimeWithZone.namewill raiseActiveSupport::DeprecationExceptionif we setconfig.active_support.deprecation = :raise, which should be common for development environment.This pr rescue irb from termination.