Remove exit command workaround, handle IRB_EXIT in debug_readline #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command was a method. It could be executed outside of IRB. Workaround for it is no longer needed.
tompng
force-pushed
the
rm_exit_workaround
branch
from
d522f83 to
364d5f8
Compare
st0012
approved these changes
Apr 19, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Apr 20, 2024
debug_readline (ruby/irb#923) * Remove exit and exti! command workaround when executed outside of IRB Command was a method. It could be executed outside of IRB. Workaround for it is no longer needed. * Handle IRB_EXIT in debug mode * Add exit and exit! command in rdbg mode ruby/irb@0b5dd6afd0
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
debug_readline (ruby/irb#923) * Remove exit and exti! command workaround when executed outside of IRB Command was a method. It could be executed outside of IRB. Workaround for it is no longer needed. * Handle IRB_EXIT in debug mode * Add exit and exit! command in rdbg mode ruby/irb@0b5dd6afd0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing workaround
Command was a method.
Now, it's not a method. Workaround for
exitandexit!is not needed anymore.Debug and exit
catch(:IRB_EXIT)was missing in handling debug command. It was working because the workaround was luckily triggered.Added catch because the workaround is removed.
Behavior change
With this ruby file
In this pull request,
debugexitprints 'hello' and moves to the next breakpoint, (just like CTRL-d input).Before this change, it was exiting process without printing 'hello'.