Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require jruby lib to get JRuby.compile_ir #93

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Require jruby lib to get JRuby.compile_ir #93

merged 1 commit into from
Mar 28, 2020

Conversation

headius
Copy link
Contributor

@headius headius commented Mar 28, 2020

For 9.3 we have made internal features of the JRuby module (like compile_ir accessible only if you require 'jruby', so that's what this PR is for. The compile_ir call errors without this:

NoMethodError: undefined method `compile_ir' for JRuby:Module
Did you mean?  Complex
          check_code_block at /Users/headius/projects/jruby/lib/ruby/gems/shared/gems/irb-1.2.1/lib/irb/ruby-lex.rb:210

@aycabta aycabta merged commit 57409f5 into ruby:master Mar 28, 2020
@aycabta
Copy link
Member

aycabta commented Mar 28, 2020

Thank you, this is an important thing.

@headius headius deleted the require_jruby branch March 29, 2020 04:18
@headius
Copy link
Contributor Author

headius commented Apr 2, 2020

Thank you! I look forward to a release (we do not commit irb sources to JRuby's repository now, and only use the gems).

@headius
Copy link
Contributor Author

headius commented Apr 13, 2020

@aycabta Can we get a release with this change? The gem that's out there no longer works on JRuby master. The fix here will work fine on all JRuby versions.

headius added a commit to headius/jruby that referenced this pull request Apr 13, 2020
@headius
Revert back to irb 1.0.0 for now
5fefd99 
Recent irb versions have code that uses JRuby.compile_ir to test
the syntax of incoming code. However we recently changed our boot
requires such that `compile_ir` is not bound by default.

This can be reverted and IRB updated once ruby/irb#93 gets into
a release.
headius added a commit to headius/jruby that referenced this pull request Apr 13, 2020
@headius
Revert back to irb 1.0.0 for now
d740174 
Recent irb versions have code that uses JRuby.compile_ir to test
the syntax of incoming code. However we recently changed our boot
requires such that `compile_ir` is not bound by default.

This can be reverted and IRB updated once ruby/irb#93 gets into
a release.
headius added a commit to headius/jruby that referenced this pull request Apr 13, 2020
@headius
Revert back to irb 1.0.0 for now
52f3012 
Recent irb versions have code that uses JRuby.compile_ir to test
the syntax of incoming code. However we recently changed our boot
requires such that `compile_ir` is not bound by default.

This can be reverted and IRB updated once ruby/irb#93 gets into
a release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@headius @aycabta