Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoize helper method instances with Singleton module #931

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Apr 24, 2024

Some helpers, like Rails console's app, requires memoization of the helper's ivars. To support it IRB needs to memoize helper method instances as well.

Some helpers, like Rails console's `app`, requires memoization of the
helper's ivars. To support it IRB needs to memoize helper method instances
as well.
@st0012 st0012 self-assigned this Apr 24, 2024
@tompng tompng merged commit a96c7a6 into master Apr 24, 2024
59 checks passed
@tompng tompng deleted the memoize-helper-methods branch April 24, 2024 18:32
matzbot pushed a commit to ruby/ruby that referenced this pull request Apr 24, 2024
(ruby/irb#931)

Some helpers, like Rails console's `app`, requires memoization of the
helper's ivars. To support it IRB needs to memoize helper method instances
as well.

ruby/irb@a96c7a6668
artur-intech pushed a commit to artur-intech/ruby that referenced this pull request Apr 26, 2024
(ruby/irb#931)

Some helpers, like Rails console's `app`, requires memoization of the
helper's ivars. To support it IRB needs to memoize helper method instances
as well.

ruby/irb@a96c7a6668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants