Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder ruby lex clauses for unrecoverable first #956

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

kddnewton
Copy link
Contributor

When a syntax error includes multiple error messages, we want to check for unrecoverable messages first so that we do not accidentally match a recoverable error later in the message.

When a syntax error includes multiple error messages, we want to
check for unrecoverable messages first so that we do not
accidentally match a recoverable error later in the message.
@kddnewton kddnewton requested a review from st0012 May 15, 2024 16:53
@st0012 st0012 added the bug Something isn't working label May 17, 2024
@st0012 st0012 merged commit 2f42b23 into master May 17, 2024
59 checks passed
@st0012 st0012 deleted the reorder-clauses branch May 17, 2024 02:44
matzbot pushed a commit to ruby/ruby that referenced this pull request May 17, 2024
(ruby/irb#956)

When a syntax error includes multiple error messages, we want to
check for unrecoverable messages first so that we do not
accidentally match a recoverable error later in the message.

ruby/irb@2f42b2360d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants